[MenuItem][Joy] Add internal id to DOM #37361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-37361--material-ui.netlify.app/ Bundle size report |
sai6855
added
package: joy-ui
sai6855
commented
May 22, 2023
| @@ -184,6 +184,20 @@ describe('Joy <MenuItem />', () => { | |||
| expect(menuitem).to.have.attribute('aria-disabled', 'true'); | |||
| }); | |||
|
|
|||
| it('should add external id to DOM and override internal id', () => { | |||
There was a problem hiding this comment.
This is passing in master too but i just wanted to add a test which tests adding extrenal id to DOM when available
sai6855
changed the title
sai6855
changed the title
|
closing in favour of #37364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspect
firstoption of both sandboxes and you can seeidis added to dom only inaftersandboxbefore: https://codesandbox.io/s/quirky-chaplygin-5skfj3?file=/demo.tsx
after: https://codesandbox.io/s/nervous-pond-l5cfzp?file=/demo.tsx
This PR fixes
adding internal
idtoMenuItemDOM when externalidis not providedovverding internal
idinuseMenuItemhook (code change) when externalidis providedI have followed (at least) the PR section of the contributing guide.